Java prerequisites for Maven Plugins fails for Java 8

[cstamas]

Affected version

3.9.12

Bug description

[WARNING] Ignoring incompatible plugin version 0.4.6:
The plugin eu.maveniverse.maven.plugins:nisse-plugin3:0.4.6 has unmet prerequisites:
Required Java version [8,) is not met by current version: 1.8.0_462

[cstamas]

Related apache/maven-plugin-tools#825

[slawekjaranowski]

Look likes nisse plugins set manually requiredJavaVersion to [8,) - I hope that simple value as 8 without range will be the same and should works.

[hboutemy]

I suppose it is introduced by #11479
stupid old 1.8 vs 8 formatting?

[cstamas]

Look likes nisse plugins set manually requiredJavaVersion to [8,) - I hope that simple value as 8 without range will be the same and should works.

Yes, in fact many Maveniverse plugin do this:
https://github.com/maveniverse/nisse/blob/17ae7c40cf7927b1f92c033d87ac36f0a6650f4a/plugin3/pom.xml#L111-L112

Defaults are set in parent:
https://github.com/maveniverse/parent/blob/5237b598c3d37d4c7e74465bcee8ad09e43f15c0/pom.xml#L116-L125

Obviously, requiredBuildtime* ones are fed to enforcer to give meaningful errors if someone tries to build project with wrong Java or Maven.

The requiredRuntime* are in case of Maven Plugins fed into maven-plugin-plugin. In case of extensions, they are filtered https://github.com/maveniverse/nisse/blob/17ae7c40cf7927b1f92c033d87ac36f0a6650f4a/extension3/src/main/filtered-resources/runtime-requirements.properties and used by this https://github.com/maveniverse/maven-shared/blob/20c8359bddcea1b82d2ed0f82e7c2646fb0b4902/extension/src/main/java/eu/maveniverse/maven/shared/extension/RuntimeRequirementEnforcerLifecycleParticipant.java

Nisse defines runtime requirement of Java 8 and Maven 3.8+.

Again, the reason is following: to have meaningful error messages.

For example: attempt to use project using Nisse (runtime req: maven 3.8+ java 8) with Maven 3.6.3:

$ mvn -V verify
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /home/cstamas/.sdkman/candidates/maven/3.6.3
Java version: 1.8.0_462, vendor: Temurin, runtime: /home/cstamas/.sdkman/candidates/java/8.0.462-tem/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "6.17.12-300.fc43.x86_64", arch: "amd64", family: "unix"
[INFO] Maveniverse Nisse 0.6.3 loaded
[INFO] Nisse injecting 23 properties into User Properties
[INFO] Scanning for projects...
[INFO] No need for inlining
[WARNING] eu.maveniverse.maven.nisse:extension3 runtime requirements are not fulfilled:
[WARNING] * Unsupported Maven version 3.6.3; supported versions are [3.8,)
[ERROR] eu.maveniverse.maven.nisse:extension3 cannot operate in this environment: adapt your environment for requirements
[ERROR] Runtime requirements are not fulfilled -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionException
$ 

[cstamas]

Given we play in two dimensions here (supported Java bytecode and supported Maven version), mixed with the fact that older Maven versions (due older Sisu with older ASM) would simply skip component bytecode that are not readable by it, component alone cannot do much about this "unsupported env error", if it is "more modern" (ie Java 17) and tried with older Maven (ie 3.6.3).

Also, given build time requirement for Maveniverse projects are consistently 21 (ie latest LTS when it all started), and to make Java 21 to produce Java 8 output one uses maven.compiler.release=8 as explained here, that same 8 was reused in this range as well, assuming is okay.... But seems is not 😞

[slawekjaranowski]

I hope only affected with jdk 1.8 with range

try to search plugins: https://github.com/search?q=%22%3CrequiredJavaVersion%3E%5B%22+language%3A%22Maven+POM%22&type=code

[slawekjaranowski]

without range it is ok, like

            <requiredJavaVersion>8</requiredJavaVersion>