Skip to content

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jul 28, 2024

@elharo elharo requested a review from michael-o July 28, 2024 12:08
@elharo elharo marked this pull request as ready for review July 28, 2024 20:20
@@ -53,16 +53,17 @@
@RunWith(JUnit4.class)
public abstract class AbstractSiteDeployWebDavTest extends AbstractMojoTestCase {

// Can use @TempDir with JUnit 5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on this

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge as soon as tests pass.

@elharo elharo merged commit 3e0c334 into master Jul 28, 2024
54 checks passed
@elharo elharo deleted the clean branch July 28, 2024 21:18
michael-o pushed a commit that referenced this pull request Jul 28, 2024
* More modern temporary file handling
@jira-importer
Copy link

Resolve #1072

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants