[MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management

[jira-importer]

Christian Schulte opened MRESOLVER-9 and commented

During dependency processing the DependencySelector is called to decide if a dependency is to be selected. The call to DependencySelector.selectDependency() is performed with the unmanaged dependency, but needs to be performed with the managed dependency. With the fix applied, the result no longer contains dependencies whose scope or optionality has been managed to not be part of the result (correct behaviour). Without the fix applied, the result contains dependencies with a managed scope or optionality not filtered out by the DependencySelector in use (incorrect behaviour).

---

Issue Links:

• MNG-6135 Maven plugins and core extensions are not dependencies, they should be resolved the same way as projects.
  ("blocks")

• MNG-5935 Optional true getting lost in managed dependencies when transitive
  ("blocks")

• MNG-7003 Inconsistent dependency tree
  ("blocks")

• MNG-5227 The 'optional' flag of a dependency should be manageable.
  ("blocks")

• MRESOLVER-235 Managed dependencies are not honoured when resolving a dependency graph

• MNG-6139 Addition of command line option 'legacy-dependency-management'.
  ("is required by")

• MRESOLVER-12 Addition of unit tests for DependencySelector implementations
  ("is depended upon by")

Remote Links:

• GitHub Pull Request #145
  
• Original bug report.
  

1 votes, 5 watchers

[jira-importer]

Christian Schulte commented

Fixed with this commit.

[jira-importer]

Christian Schulte commented

Issue is fixed in the master branch of my private maven repository on github. When interested, you can cherry pick the commit to your own repository and create a pull request for the apache master branch with just this commit yourself from there.

[jira-importer]

Michael Osipov commented

This change causes failures in Resolver, Maven, Maven ITs. If the the tests from the former two are changed, we have this in ITs:

[ERROR] Failures:
[ERROR]   MavenITmng4600DependencyOptionalFlagManagementTest>AbstractMavenIntegrationTestCase.runTest:222->testitResolution:86 [classes, direct-0.2.jar]
[ERROR] Errors:
[ERROR]   MavenITmng3259DepsDroppedInMultiModuleBuildTest>AbstractMavenIntegrationTestCase.runTest:222->testitMNG3259:62 » Verification