Skip to content

Rephrase source code fix interactive messages for clarity #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025
Merged

Rephrase source code fix interactive messages for clarity #390

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a55e8bb
rewrite source code fix user messages for clarity
elharo Jun 3, 2025
e1f5da9
spelling
elharo Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/main/java/org/apache/maven/plugins/javadoc/AbstractFixJavadocMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ private boolean preCheck() throws MojoExecutionException {
}

if (!settings.isInteractiveMode()) {
getLog().error("Maven is not attempt to interact with the user for input. "
getLog().error("Maven is not interacting with the user for input. "
+ "Verify the <interactiveMode/> configuration in your settings.");
return false;
}
Expand All @@ -579,11 +579,12 @@ private boolean preCheck() throws MojoExecutionException {
getLog().warn("");
getLog().warn("All warranties with regard to this Maven goal are disclaimed!");
getLog().warn("The changes will be done directly in the source code.");
getLog().warn("The Maven Team strongly recommends the use of a SCM software BEFORE executing this goal.");
getLog().warn(
"The Maven Team strongly recommends committing the code to source code management BEFORE executing this goal.");
getLog().warn("");

while (true) {
getLog().info("Are you sure to proceed? [Y]es [N]o");
getLog().info("Are you sure you want to proceed? [Y]es [N]o");

try {
String userExpression = inputHandler.readLine();
Expand All @@ -592,7 +593,7 @@ private boolean preCheck() throws MojoExecutionException {
break;
}
if (JavadocUtil.equalsIgnoreCase(userExpression, "N", "No")) {
getLog().info("No changes in your sources occur.");
getLog().info("OK, I will not change your source code.");
return false;
}
} catch (IOException e) {
Expand Down Expand Up @@ -737,9 +738,9 @@ private void parseClirrTextOutputFile(File clirrTextOutputFile) throws IOExcepti
}
}
if (clirrNewClasses.isEmpty() && clirrNewMethods.isEmpty()) {
getLog().info("Clirr NOT found API differences.");
getLog().info("Clirr did NOT find any API differences.");
} else {
getLog().info("Clirr found API differences, i.e. new classes/interfaces or methods.");
getLog().info("Clirr found API differences; e.g. new classes, interfaces, or methods.");
}
}

Expand Down