Issue #369 Support --no-fonts option per default for jdk 23+ #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Lamy <[email protected]>
slawekjaranowski
approved these changes
May 29, 2025
KroArtem
reviewed
Jul 8, 2025
| /** | ||
| * From jdk 23, javadoc now include some extra css, files which can increase the size of javadoc jar. | ||
| * This can be disabled using the option {@code --no-fonts} | ||
| * The javadoc plugin will add this option to diable extra files to be added per default. |
KroArtem
reviewed
Jul 8, 2025
| * From jdk 23, javadoc now include some extra css, files which can increase the size of javadoc jar. | ||
| * This can be disabled using the option {@code --no-fonts} | ||
| * The javadoc plugin will add this option to diable extra files to be added per default. | ||
| * If you prefer the new font you must set to {@code true} the option {@code disableNoFonts} |
There was a problem hiding this comment.
IMO a parameter with double negative is hard to understand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olivier Lamy [email protected]
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.