[MJAR-296] Allow including files excluded by default. #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
reviewed
Nov 19, 2023
redzi
force-pushed
the
MJAR-296-suppress-default-excludes
branch
from
4e85e6c to
f811a85
Compare
src/it/MJAR-296/verify.groovy
Outdated
Comment on lines
28
to
31
| if ( !target.exists() || !target.isDirectory() ) { | ||
| System.err.println( "target file is missing or not a directory." ) | ||
| return result | ||
| } |
Member
There was a problem hiding this comment.
We can simply use:
assert target.isDirectory()
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
Outdated
Show resolved
Hide resolved
slawekjaranowski
force-pushed
the
MJAR-296-suppress-default-excludes
branch
from
f811a85 to
bd967a2
Compare
Member
|
@redzi , @michael-o - fixed and tested - should be ok |
michael-o
requested changes
Apr 9, 2024
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
Outdated
Show resolved
Hide resolved
michael-o
approved these changes
Apr 9, 2024
Member
michael-o
left a comment
michael-o
left a comment
There was a problem hiding this comment.
One nit from my side, but the rest is fine!
|
Resolve #441 |
1 similar comment
|
Resolve #441 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MJAR-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MJAR-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.
Underlining issue: MJAR-296.
Goal: