feat(config): allow to configure the rocksdb.sst_file_delete_rate_bytes_per_sec #3040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@sryanyuan Thanks for your contribution. Could you please add a test case in config_test.go to ensure this configuration? |
Contributor
Author
Done |
git-hulk
reviewed
Jun 27, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PurgeObsoleteFiles will be called during compaction, flush, and similar operations, and it will be performed in the background threads (avoid-unnecessary-blocking-io is enabled).
Additionally, it may also be triggered when destroying an iterator in a user thread, in the case:
SST files will be deleted by background threads
while archived WAL log files will be unlinked directly in the user thread.
This design might cause high latency if there are many files to be deleted.
rocksdb.sst_file_delete_rate_bytes_per_sec can set the delete rate limit in bytes per second for SST files deletion.
In scenarios involving frequent database iterations (e.g., HGETALL, SCAN) obsolete WAL files may be deleted synchronously, causing latency spikes. Enabling this option activates a controlled slow deletion mechanism, which also resolves WAL deletion latency issues when an iterator is released.