Skip to content

fix(config): Parse rocksdb.max_bytes_for_level_base as uint64_t #3032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
git-hulk merged 2 commits into from
Jun 21, 2025
Merged

fix(config): Parse rocksdb.max_bytes_for_level_base as uint64_t #3032

git-hulk merged 2 commits into from
Jun 21, 2025

Conversation

@Ryan4253
Copy link
Contributor

@Ryan4253 Ryan4253 commented Jun 20, 2025 •
edited
Loading

Closes #3031

Summary of Changes

Makes rocksdb.max_bytes_for_level_base a uint64_t and is parsed as one so users can set value to be over 2^31-1 bytes

Test Plan

Unit Test

[----------] Global test environment tear-down
[==========] 431 tests from 69 test suites ran. (68246 ms total)
[  PASSED  ] 430 tests.
[  SKIPPED ] 1 test, listed below:
[  SKIPPED ] UseBitmap/RedisBitmapTest.BitfieldStringGetSetTest/0

RocksDB Logs

2025/06/20-12:14:37.264568 129161                Options.max_bytes_for_level_base: 2147483648

@Ryan4253 Ryan4253 marked this pull request as ready for review June 20, 2025 16:15
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 20, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
60.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@git-hulk git-hulk merged commit 2f2c11d into apache:unstable Jun 21, 2025
36 checks passed
@Ryan4253 Ryan4253 deleted the max-level-byte branch July 4, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@git-hulk git-hulk git-hulk approved these changes

@mapleFU mapleFU mapleFU approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't set rocksdb.max_bytes_for_level_base to over 2GB

3 participants

@Ryan4253 @git-hulk @mapleFU