fix: Unset change_level if level_compaction_dynamic_level_bytes is enabled #3020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hotpxl
changed the title
git-hulk
approved these changes
Jun 7, 2025
|
LindaSummer
approved these changes
Jun 8, 2025
Member
LindaSummer
left a comment
LindaSummer
left a comment
There was a problem hiding this comment.
Thanks very much for your effort!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See facebook/rocksdb#13671 for more details, but TLDR is when both
change_levelandlevel_compaction_dynamic_level_bytesare set, RocksDB will try to thrash the data between L1 and L6. Underlevel_compaction_dynamic_level_bytes, the intention is to fill up the "base" level first to reduce storage amplification, so we should not setchange_levelFixes #2601