-
Notifications
You must be signed in to change notification settings - Fork 592
feat(config): allow to configure the rocksdb.min_write_buffer_number_to_merge #3016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: hulk <[email protected]>
Co-authored-by: hulk <[email protected]>
Co-authored-by: hulk <[email protected]>
|
|
thanks for the review and edits! just fyi the edits would introduce a slight behavior change, since the original line of code reads ie. a default value of 2, which will now be 1. |
|
@nathanlo-hrt Oh? where's this assignment? It will default to 1 from the rocksdb source code: https://github.com/facebook/rocksdb/blob/7d80ea45442e84c25669db61cb7376ba0cd10ba5/include/rocksdb/advanced_options.h#L187 |
|
@nathanlo-hrt Thank you. I'm sorry that I didn't notice this option has ever been set in Kvrocks, but it should be good to keep the same default value with RocksDB. |


It's useful to configure this.