Skip to content

Conversation

@nathanlo-hrt
Copy link
Contributor

It's useful to configure this.

@git-hulk git-hulk changed the title feat: Make rocksdb.min_write_buffer_number_to_merge configurable feat(config): allow to configure the rocksdb.min_write_buffer_number_to_merge Jun 5, 2025
@PragmaTwice PragmaTwice requested a review from git-hulk June 5, 2025 04:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
29.2% Coverage on New Code (required ≥ 50%)

See analysis details on SonarQube Cloud

@PragmaTwice PragmaTwice merged commit 065d4cf into apache:unstable Jun 5, 2025
35 of 36 checks passed
@nathanlo-hrt
Copy link
Contributor Author

thanks for the review and edits! just fyi the edits would introduce a slight behavior change, since the original line of code reads

  options.min_write_buffer_number_to_merge = 2;

ie. a default value of 2, which will now be 1.

@git-hulk
Copy link
Member

git-hulk commented Jun 6, 2025

@nathanlo-hrt
Copy link
Contributor Author

nathanlo-hrt commented Jun 6, 2025

@git-hulk
Copy link
Member

git-hulk commented Jun 6, 2025

https://github.com/apache/kvrocks/blame/644c6b7666a93e1134641613fb715913ad02beaa/src/storage/storage.cc#L172C12-L172C12

@nathanlo-hrt Thank you. I'm sorry that I didn't notice this option has ever been set in Kvrocks, but it should be good to keep the same default value with RocksDB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants