chore(log): replace logging calls in storage/* #2909
Conversation
src/storage/event_listener.cc
Outdated
| void EventListener::OnTableFileDeleted(const rocksdb::TableFileDeletionInfo &info) { | ||
| LOG(INFO) << "[event_listener/table_file_deleted] db: " << info.db_name << ", sst file: " << info.file_path | ||
| << ", status: " << info.status.ToString(); | ||
| void EventListener::OnTableFileDeleted(const rocksdb::TableFileDeletionInfo &info_) { |
There was a problem hiding this comment.
@PragmaTwice Hi, i had to rename the function parameter to info_ for some functions as it was conflicting with the spdlog's info.
|
@PragmaTwice |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the logging calls in the storage module to use the new logging functions (info, warn, error, and debug) instead of the old LOG macros. The changes provide a consistent, structured, and modern logging style across several storage-related files.
- Replaced LOG macros with their corresponding logging functions throughout the storage, scripting, and utility modules.
- Updated format strings to use "{}" placeholders for parameter insertion.
- Made minor stylistic changes in initializer lists and formatting for consistency.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/storage/storage.cc | Replaced LOG calls with info/warn/error logging calls. |
| src/storage/scripting.cc | Updated logging for Lua commands with new logging funcs. |
| src/storage/iterator.h | Adjusted initializer lists for consistency. |
| src/storage/event_listener.cc | Refactored logging calls in event callbacks. |
| src/storage/compaction_checker.cc | Updated logging for compaction operations. |
| src/storage/compact_filter.cc | Replaced logging calls with warn/error and debug. |
| src/storage/batch_extractor.cc | Refactored LOG messages to error/warn messages. |
|
2 participants
Part of #2889