chore(log): replace logging calls in cluster/*

[SharonIV0x86]

Related to #2889

[PragmaTwice]

Suggested change

	info("Change server role to master, restart migration task")
	info("Change server role to master, restart migration task");

?

[PragmaTwice]

Please review every change you made. So many mistakes..

[PragmaTwice]

Looks good to me now : )

[PragmaTwice]

Some syntax errors. Did you try to compile the code after these changes?

[SharonIV0x86]

Some syntax errors. Did you try to compile the code after these changes?

I did, ill look into it right now.

[SharonIV0x86]

@PragmaTwice Should work now.
Apologies for the earlier mistakes, I was in a bit of a rush while working on the PR, which I realize I shouldn't have been. I'll make sure to be more careful going forward.

On a another note, I had a quick question regarding my GSoC proposal on database backups. Since the Kvrocks community page mentions that all important decisions should go through the mailing list, do I need to share my proposal there as well for visibility and feedback? Just want to make sure I'm following the right process. Thanks.

[SharonIV0x86]

implicit instantiation of undefined template 'fmt::detail::type_is_unformattable_for<SSLErrors, char>'
    type_is_unformattable_for<T, char_type> _;

Seems to be an issue from here.

error("Failed to construct SSL structure for new connection: {}", SSLErrors{});

Doing this might work? as it says here gabime/spdlog#2041 (comment)

std::ostringstream oss;
oss << SSLErrors{};
error("Failed to construct SSL structure for new connection: {}", oss.str());

[PragmaTwice]

You can try fmt::streamed(SSLErrors{})

[sonarqubecloud]

Quality Gate failed

Failed conditions
38.1% Coverage on New Code (required ≥ 50%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE