Skip to content

Conversation

@PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Apr 14, 2025

It closes #2267.

  • A new header common/logging.h to provide log functions and also simulation interfaces of glog so that we don't need to replace all logging call LOG(..) in this PR;
  • clang minimum requirement bumped form 8 to 9;
  • support multiple destination in config option log-dir.

@PragmaTwice PragmaTwice requested a review from git-hulk April 14, 2025 17:49
@PragmaTwice PragmaTwice marked this pull request as draft April 14, 2025 18:13
Signed-off-by: PragmaTwice <[email protected]>
Signed-off-by: PragmaTwice <[email protected]>
@PragmaTwice PragmaTwice marked this pull request as ready for review April 15, 2025 02:33
@PragmaTwice PragmaTwice requested a review from git-hulk April 20, 2025 07:44
@PragmaTwice PragmaTwice merged commit 7770f13 into apache:unstable Apr 20, 2025
33 checks passed
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate the possiblity and method to replace GLOG with spdlog

3 participants