Skip to content

Conversation

@aleksraiden
Copy link
Contributor

Bump jsoncons v1.3.0, release notes - https://github.com/danielaparker/jsoncons/releases/tag/v1.3.0

Fix bugs and implements json_options members allow_comments and allow_trailing_comma - as I see for us.

@torwig
Copy link
Contributor

torwig commented Mar 5, 2025

Maybe a flaky test:

--- FAIL: TestReplicationWithLimitSpeed (38.06s)
    --- FAIL: TestReplicationWithLimitSpeed/resume_broken_transfer_based_files (31.29s)
        client.go:49: 
            	Error Trace:	/home/runner/work/kvrocks/kvrocks/tests/gocase/util/client.go:49
            	            				/home/runner/work/kvrocks/kvrocks/tests/gocase/integration/replication/replication_test.go:332
            	Error:      	Condition never satisfied
            	Test:       	TestReplicationWithLimitSpeed/resume_broken_transfer_based_files
FAIL

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2025

@PragmaTwice PragmaTwice merged commit f060d18 into unstable Mar 6, 2025
69 checks passed
@aleksraiden aleksraiden deleted the aleksraiden-patch-1 branch March 6, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants