Skip to content

chore(server): return InfoEntries instead of string in Get..Info() #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PragmaTwice merged 2 commits into from
Feb 9, 2025
Merged

chore(server): return InfoEntries instead of string in Get..Info() #2778

PragmaTwice merged 2 commits into from
Feb 9, 2025

Conversation

@PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Feb 8, 2025 •
edited
Loading

AS IS:

std::string GetXXXInfo();

TO BE:

using InfoEntries = std::vector<InfoEntry>;

InfoEntries GetXXXInfo();

@PragmaTwice PragmaTwice requested a review from git-hulk February 8, 2025 14:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
61.0% Coverage on New Code
1.3% Duplication on New Code

See analysis details on SonarQube Cloud

@PragmaTwice PragmaTwice merged commit 5055f57 into apache:unstable Feb 9, 2025
36 checks passed
@ltagliamonte-dd ltagliamonte-dd mentioned this pull request Apr 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@torwig torwig torwig approved these changes

@git-hulk git-hulk Awaiting requested review from git-hulk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PragmaTwice @torwig