perf(cluster): add upper bound for scan during migration #2724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiversJin
force-pushed
the
perf/migrate
branch
from
fd18f73 to
794e201
Compare
PragmaTwice
reviewed
Jan 17, 2025
Co-authored-by: Twice <[email protected]>
danishgh
approved these changes
Jan 18, 2025
git-hulk
approved these changes
Jan 19, 2025
|
PragmaTwice
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting an upper bound in advance during the scan, it can prevent RocksDB from having to scan through a block of tombstone data before stopping in certain situations.