feat(config): add the partition_filters option to disable the partitioned filters
#2688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PragmaTwice
reviewed
Dec 6, 2024
src/config/config.cc
Outdated
Comment on lines
134
to
135
| const std::string compression_per_level = | ||
| util::StringJoin(compression_per_level_builder, [](const auto &s) -> decltype(auto) { return s; }, ":"); |
Member
There was a problem hiding this comment.
Seems we need to revert this change to make CI pass.
Note that in the CI the clang-format version is 14. Different versions may lead to different format results.
PragmaTwice
reviewed
Dec 6, 2024
Member
There was a problem hiding this comment.
Please avoid introducing unrelated changes.
Also please ensure the version of clang-format you are using is 14. You can download it from here.
cxljs
force-pushed
the
conf_partition_filters
branch
from
4fc07cc to
113bd72
Compare
Contributor
Author
thanks, I fixed it. |
PragmaTwice
approved these changes
Dec 6, 2024
Member
PragmaTwice
left a comment
PragmaTwice
left a comment
There was a problem hiding this comment.
LGTM. Thank you for your contribution!
git-hulk
approved these changes
Dec 6, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It closes #2676.