feat(cluster): add support of the JSON type in cluster migration #2654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PragmaTwice
reviewed
Nov 10, 2024
PragmaTwice
reviewed
Nov 10, 2024
PragmaTwice
reviewed
Nov 10, 2024
src/types/redis_json.cc
Outdated
| return rocksdb::Status::OK(); | ||
| } | ||
|
|
||
| rocksdb::Status Json::FromRawString(const std::string &value, JsonValue *result) { |
Member
There was a problem hiding this comment.
Suggested change
| rocksdb::Status Json::FromRawString(const std::string &value, JsonValue *result) { | |
| rocksdb::Status Json::FromRawString(std::string_view value, JsonValue *result) { |
git-hulk
force-pushed
the
feature/support-json-type-in-migration
branch
from
171e343 to
176e8fd
Compare
git-hulk
force-pushed
the
feature/support-json-type-in-migration
branch
from
176e8fd to
9a6fab1
Compare
caipengbo
previously approved these changes
Nov 11, 2024
git-hulk
force-pushed
the
feature/support-json-type-in-migration
branch
from
9a6fab1 to
7feb984
Compare
PragmaTwice
approved these changes
Nov 11, 2024
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #2583.