Skip to content

Conversation

@paragor
Copy link
Contributor

@paragor paragor commented Oct 17, 2024

issue: #2606

add rocksdb.wal_compression to allow enable wal compression
only zstd supported, so field YesOrNo

# the WAL is read.
#
# Default is no
rocksdb.wal_compression no
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be none and zstd instead of no and yes to leave some upgrading space.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i will fix it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@aleksraiden aleksraiden requested a review from torwig October 17, 2024 09:58
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
38.6% Coverage on New Code (required ≥ 50%)

See analysis details on SonarCloud

@PragmaTwice PragmaTwice merged commit 4709734 into apache:unstable Oct 18, 2024
@mapleFU
Copy link
Member

mapleFU commented Oct 18, 2024

By the way, may I ask that is this only for write-heavy workload(maybe with long and compress-able key-values)?

@paragor
Copy link
Contributor Author

paragor commented Oct 18, 2024

By the way, may I ask that is this only for write-heavy workload(maybe with long and compress-able key-values)?

i have a lot key-value (uncompressed size in [256B, 8kB]) with good compression rate (value is json, where sum length of json's keys is bigger then json's values).
i have ~100-200MB/s write, wal and compaction load, so on aws i need use aws ec2 instances with enough cpu (see ec2 instance throughput limits https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ebs-optimized.html).

finally i have a lot of free cpu. this pull request can help me decrease write load on disk and i can pickup cheaper ec2

@mapleFU
Copy link
Member

mapleFU commented Oct 18, 2024

I see, this make sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants