Fix the replica should remove the master link when receiving the CLUSTER RESET command #2259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
commented
Apr 20, 2024
| require.Contains(t, rdb0.ClusterResetHard(ctx).Err(), "Can't reset cluster while database is not empty") | ||
| require.NoError(t, rdb0.Del(ctx, key).Err()) | ||
| require.NoError(t, rdb0.Do(ctx, "cluster", "reset").Err()) | ||
| require.NoError(t, rdb0.ClusterResetSoft(ctx).Err()) |
Member
Author
There was a problem hiding this comment.
Use to confirm the CLUSTER RESET SOFT also works well.
git-hulk
force-pushed
the
fix-remove-master-in-cluster-reset
branch
from
3ce8163 to
bf2992d
Compare
PragmaTwice
reviewed
Apr 20, 2024
…TER RESET command This PR also allows using SOFT|HARD in the CLUSTER RESET command, but it's the same meaning to the Kvrocks cluster since kept the cluster current epoch(version) is meaningless to it.
git-hulk
force-pushed
the
fix-remove-master-in-cluster-reset
branch
from
bf2992d to
8ac496d
Compare
PragmaTwice
approved these changes
Apr 20, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also allows using SOFT|HARD in the CLUSTER RESET command,
but it has the same meaning in the Kvrocks cluster since keeping
the cluster's current epoch(version) is meaningless to it.