Add the support of RESP3 map type #2028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
git-hulk
force-pushed
the
add-resp3-map
branch
from
63fcf5b to
21e286d
Compare
PragmaTwice
reviewed
Jan 20, 2024
git-hulk
force-pushed
the
add-resp3-map
branch
from
a0c6b56 to
2dff54f
Compare
PragmaTwice
reviewed
Jan 20, 2024
PragmaTwice
approved these changes
Jan 21, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly supports the RESP3 map type. But we found the FUNCTION LIST command
output now is an array of bulk strings like
["function_name","add","library":"lib1"].To align with Redis's format which is an array of arrays that should be:
[["function_name","add"], ["library":"lib1"]].We must mention the breaking change in the FUNCTION LIST command output in our next release notes.
Most codes are changed in test cases to ensure RESP3 is working well.
This closes #1996