The storage engine type awareness in Kvrocks

[MaheshMadushan]

#1966

Storage Engine Type Enum
enum class StorageEngineType : uint16_t { RocksDB, Speedb, };

Storage type stored in variable STORAGE_ENGINE_TYPE in src/storage.h. it can be StorageEngineType::RocksDB or StorageEngineType::Speedb

[git-hulk]

LGTM, thank you!

[PragmaTwice]

BTW, I think we can have an enum type in our code.

[MaheshMadushan]

BTW, I think we can have an enum type in our code.

Under the namespace engine in src/storage.h following enum can be created.
enum class Type { RocksDB, Speedb, };

Then we can have macros for storage engine as following,
STORAGE_ENGINE=0 # for rocksdb
STORAGE_ENGINE=1 # for speedb

Then we can determine the engine type as following,
if (STORAGE_ENGINE == static_cast<int>(engine::Type::RocksDB)) {} ...

Would that be ideal?

[PragmaTwice]

BTW, I think we can have an enum type in our code.

Under the namespace engine in src/storage.h following enum can be created.
enum class Type { RocksDB, Speedb, };

Then we can have macros for storage engine as following,
STORAGE_ENGINE=0 # for rocksdb
STORAGE_ENGINE=1 # for speedb

Then we can determine the engine type as following,
if (STORAGE_ENGINE == static_cast<int>(engine::Type::RocksDB)) {} ...

Would that be ideal?

Firstly, the enum type can definitely have a better name than Type.

Besides, we can have a static-storage-duration constant to wrap the macro, so that we don't need to do any type cast.

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[PragmaTwice]

Thank you for your contribution!