Skip to content

Optimize ParseMetadata by introducing RedisTypes #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PragmaTwice merged 2 commits into from
Dec 24, 2023
Merged

Optimize ParseMetadata by introducing RedisTypes #1967

PragmaTwice merged 2 commits into from
Dec 24, 2023

Conversation

@PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Dec 24, 2023 •
edited
Loading

Both construction of std::vector<RedisType> and vector<T>::find is not efficient enough.

Here we use bitmap to make it faster and avoid memory allocation.

@PragmaTwice PragmaTwice requested a review from git-hulk December 24, 2023 13:31
git-hulk
git-hulk previously approved these changes Dec 24, 2023
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cool!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 24, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
1.6% Duplication on New Code

See analysis details on SonarCloud

@PragmaTwice PragmaTwice merged commit b0b1b4e into apache:unstable Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@git-hulk git-hulk git-hulk approved these changes

@torwig torwig torwig approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PragmaTwice @git-hulk @torwig