Skip to content

Use human readable string instead of the integer when printing flush/compaction reason #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PragmaTwice merged 6 commits into from
Feb 1, 2024
Merged

Use human readable string instead of the integer when printing flush/compaction reason #1962

PragmaTwice merged 6 commits into from
Feb 1, 2024

Conversation

@git-hulk
Copy link
Member

@git-hulk git-hulk commented Dec 20, 2023

Before applying this patch:

column family: metadata, job_id: 59, compaction reason: 1, output compression type: no

And after this patch:

column family: metadata, job_id: 59, compaction reason: LevelMaxLevelSize, output compression type: no

@git-hulk git-hulk marked this pull request as draft December 20, 2023 14:37
@git-hulk
Copy link
Member Author

git-hulk commented Dec 20, 2023

Need to hold this PR till the speedb supports those functions.

PragmaTwice
PragmaTwice reviewed Dec 20, 2023
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 20, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
2.0% Duplication on New Code

See analysis details on SonarCloud

@git-hulk git-hulk mentioned this pull request Dec 23, 2023
Merged
@git-hulk git-hulk marked this pull request as ready for review February 1, 2024 04:24
mapleFU
mapleFU reviewed Feb 1, 2024
View reviewed changes
git-hulk
git-hulk commented Feb 1, 2024
View reviewed changes
mapleFU
mapleFU approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@mapleFU mapleFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
60.8% Coverage on New Code
1.4% Duplication on New Code

See analysis details on SonarCloud

@PragmaTwice PragmaTwice merged commit 40e996c into apache:unstable Feb 1, 2024
JoverZhang pushed a commit to JoverZhang/kvrocks that referenced this pull request Feb 24, 2024
@git-hulk @PragmaTwice @JoverZhang
Use human readable string instead of the integer when printing flush/…
d309c54 
…compaction reason (apache#1962)

Co-authored-by: Twice <[email protected]>
@git-hulk git-hulk mentioned this pull request Mar 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PragmaTwice PragmaTwice PragmaTwice approved these changes

@mapleFU mapleFU mapleFU approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@git-hulk @PragmaTwice @mapleFU