Add SET command KEEPTLE and GET options supported #1935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
requested review from
PragmaTwice,
enjoy-binbin,
git-hulk and
torwig
git-hulk
reviewed
Dec 16, 2023
Member
git-hulk
left a comment
git-hulk
left a comment
There was a problem hiding this comment.
Overall is good, thanks for your contribution.
PragmaTwice
reviewed
Dec 16, 2023
Co-authored-by: Twice <[email protected]>
git-hulk
previously approved these changes
Dec 17, 2023
enjoy-binbin
previously approved these changes
Dec 18, 2023
|
git-hulk
approved these changes
Dec 18, 2023
enjoy-binbin
approved these changes
Dec 18, 2023
Member
Author
|
@git-hulk Maybe we need to add a note to the documentation, telling users that the next version（2.8）supports the SET option with KEEPTLE and GET options? |
Member
|
@jihuayu Sure, thank you! |
Member
|
It feels like it could also be included in #1929 and done together |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #1925
In this PR, I have added support for
KEEPTLEandGEToptions in theSETcommand.I have also updated the
GETSET,SETEX,SETNX, andSETXXcommands to use the newsetfunction.By the way, I have a question about when to use
std::optional<std::string>&and when to usestd::string*?I think that both options are equivalent, but using
std::optional<std::string>&can help avoid null in the code.So I have used
std::optional<std::string>&in my code.