KAFKA-19752: Move UnifiedLogTest to storage module (1/N) #20635
+919
−543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
TaiJuWu
force-pushed
the
UnifiedLogTest
branch
from
35b5395 to
272cefe
Compare
This reverts commit 272cefe.
chia7712
reviewed
Nov 1, 2025
| * Helper functions for writing unit tests. | ||
| * <p> | ||
| * <b>Package-private:</b> Not intended for use outside {@code org.apache.kafka.common.test}. | ||
| * Use {@code org/apache/kafka/test/TestUtils} instead. |
Collaborator
Author
There was a problem hiding this comment.
Due to this package is not public, the intention is letting other person know where can find the TestUtil could be used.
If there is no comment, we need to extra time to find it
| build(); | ||
| } | ||
|
|
||
| public static MemoryRecords singletonRecords(byte[] value, byte[] key) { |
Member
There was a problem hiding this comment.
Could you move those helpers to UnifiedLogTest?
chia7712
approved these changes
Nov 2, 2025
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
LGTM
there are some unused methods, but I assume they will be used in the follow-up
chia7712
reviewed
Nov 2, 2025
| } | ||
|
|
||
| log.updateHighWatermark(log.logEndOffset()); | ||
| log.deleteOldSegments(); |
Member
There was a problem hiding this comment.
could you add assert to ensure it does delete some segments?
Member
|
@TaiJuWu could you fix the conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates several unit tests from UnifiedLogTest.scala to
UnifiedLogTest.java as part of the ongoing effort to convert core broker
logic and tests to Java.
The following test methods have been rewritten and moved:
shouldDeleteSegmentsReadyToBeDeletedWhenCleanupPolicyIsCompactAndDelete
followerShouldSaveEpochInformationFromReplicatedMessagesToTheEpochCache
New Utility Methods: To support the Java tests, new utility methods,
including LogConfigBuilder and transactional append helpers, were added
to LogTestUtils.java.
Reviewers: Chia-Ping Tsai [email protected]