Skip to content

MINOR: Add doc for external schemas in JSONConverter #20429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

MINOR: Add doc for external schemas in JSONConverter #20429

wants to merge 3 commits into from

Conversation

JimmyWang6
Copy link
Contributor

This is a follow-up to #19449, which do the following things:

  1. Add document to explain schema.content only work for sink connector when schemas.enable set to true.
  2. Handle the case that while jsonValue contains the schema and payload fields, we should use the corresponding value.

cc @priyankaku @chia7712 .

@github-actions github-actions bot added triage PRs from the community connect small Small PRs labels Aug 28, 2025
@priyankaku
Copy link
Contributor

@JimmyWang6 : Thanks for raising this , Looks good to me!

frankvicky
frankvicky reviewed Sep 2, 2025
View reviewed changes
Copy link
Contributor

@frankvicky frankvicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JimmyWang6: Please fix the failed tests.

@github-actions github-actions bot removed the triage PRs from the community label Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankvicky frankvicky frankvicky left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ci-approved connect small Small PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JimmyWang6 @priyankaku @frankvicky @chia7712