-
Notifications
You must be signed in to change notification settings - Fork 14.6k
[WIP] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values #20334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
MirrorCheckpointConfig
MirrorConnectorConfig, ConsumerConfig, ProducerConfig, MirrorSourceConfig
This reverts commit f603b75.
The Please refer this testcase: kafka/connect/transforms/src/test/java/org/apache/kafka/connect/transforms/HeaderFromTest.java Line 240 in 18045c6
|
The |
…ConfigTest, KafkaConsumerTest
We add the three main changes in this PR
since users cannot explicitly set a configuration to null in a
properties file. Therefore, only configurations with a default value of
null should be allowed to accept null.
known configurations in Kafka that require specifying the same value
multiple times. Allowing duplicates is both rare in practice and
potentially confusing to users.
accept them. In practice, setting an empty list for several of these
configurations can lead to server startup failures or unexpected
behavior. Therefore, enforcing non-empty lists helps prevent
misconfiguration and improves system robustness.
These changes may introduce some backward incompatibility, but this
trade-off is justified by the significant improvements in safety,
consistency, and overall user experience.
Additionally, we introduce two minor adjustments:
those using comma-separated values to represent multiple entries. This
change reflects the actual semantics used in Kafka.
other configs.
These changes will not introduce any compatibility issues.