Skip to content

KAFKA-19413: Extended AuthorizerIntegrationTest to cover StreamsGroupDescribe #19981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

lucasbru
Copy link
Member

@lucasbru lucasbru commented Jun 17, 2025

Extending test coverage of authorization for streams group RPC
StreamsGroupDescribe. The RPC requires DESCRIBE GROUP and DESCRIBE TOPIC
permissions for all topics.

Reviewers: Bill Bejeck [email protected]

@lucasbru lucasbru requested a review from Copilot June 17, 2025 15:10
@github-actions github-actions bot added core Kafka Broker tests Test fixes (including flaky tests) labels Jun 17, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request extends the authorization integration tests to cover the StreamsGroupDescribe RPC. Key changes include updating the test harness with a new streams consumer configuration and methods, and adding multiple parameterized tests in AuthorizerIntegrationTest to validate authorization for streams group operations.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala Added streams consumer configuration and management methods to support StreamsGroupDescribe testing.
core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala Introduced streams group describe ACLs and tests to verify behavior under different ACL configurations.

@lucasbru lucasbru requested a review from bbejeck June 17, 2025 15:12
@lucasbru lucasbru added the KIP-1071 PRs related to KIP-1071 label Jun 17, 2025
Copy link
Member

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - assuming all tests pass

@lucasbru lucasbru merged commit 2a06335 into apache:trunk Jun 18, 2025
27 checks passed
lucasbru added a commit that referenced this pull request Jun 18, 2025
…Describe (#19981)

Extending test coverage of authorization for streams group RPC
StreamsGroupDescribe. The RPC requires DESCRIBE GROUP and DESCRIBE TOPIC
permissions for all topics.

Reviewers: Bill Bejeck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Kafka Broker KIP-1071 PRs related to KIP-1071 tests Test fixes (including flaky tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants