Skip to content

MINOR: Restore original behavior of GroupAuthorizerIntegrationTest #19968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 22, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,9 @@ private AccessControlEntry createAcl(AclOperation aclOperation, AclPermissionTyp
}

private void addAndVerifyAcls(Set<AccessControlEntry> acls, ResourcePattern resource, ClusterInstance clusterInstance) throws InterruptedException {
List<AclBinding> aclBindings = acls.stream().map(acl -> new AclBinding(resource, acl)).toList();
List<AclBinding> aclBindings = acls.stream()
.map(acl -> new AclBinding(resource, acl))
.toList();
Authorizer authorizer = getAuthorizer(clusterInstance);
authorizer.createAcls(ANONYMOUS_CONTEXT, aclBindings)
.forEach(future -> {
Expand All @@ -155,6 +157,29 @@ private void addAndVerifyAcls(Set<AccessControlEntry> acls, ResourcePattern reso
clusterInstance.waitAcls(aclBindingFilter, acls);
}

private void removeAndVerifyAcls(Set<AccessControlEntry> deleteAcls, ResourcePattern resource, ClusterInstance clusterInstance) throws InterruptedException {
List<AclBindingFilter> aclBindingFilters = deleteAcls.stream()
.map(acl -> new AclBindingFilter(resource.toFilter(), acl.toFilter()))
.toList();
Authorizer authorizer = getAuthorizer(clusterInstance);
authorizer.deleteAcls(ANONYMOUS_CONTEXT, aclBindingFilters)
.forEach(future -> {
try {
future.toCompletableFuture().get();
} catch (InterruptedException | ExecutionException e) {
throw new RuntimeException("Failed to delete ACLs", e);
}
});

AclBindingFilter aclBindingFilter = new AclBindingFilter(resource.toFilter(), AccessControlEntryFilter.ANY);
TestUtils.waitForCondition(() -> {
Set<AccessControlEntry> remainingAclEntries = new HashSet<>();
authorizer.acls(aclBindingFilter).forEach(aclBinding -> remainingAclEntries.add(aclBinding.entry()));
return deleteAcls.stream().noneMatch(remainingAclEntries::contains);
}, "Failed to verify ACLs deletion");
}


static final AuthorizableRequestContext ANONYMOUS_CONTEXT = new AuthorizableRequestContext() {
@Override
public String listenerName() {
Expand Down Expand Up @@ -253,17 +278,27 @@ public void testUnauthorizedProduceAndConsume(ClusterInstance clusterInstance, G
}
}

@ClusterTest
public void testClassicConsumeUnsubscribeWithGroupPermission(ClusterInstance clusterInstance) throws ExecutionException, InterruptedException {
testConsumeUnsubscribeWithOrWithoutGroupPermission(clusterInstance, GroupProtocol.CLASSIC, true);
}

@ClusterTest
public void testAsyncConsumeUnsubscribeWithGroupPermission(ClusterInstance clusterInstance) throws ExecutionException, InterruptedException {
testConsumeUnsubscribeWithOrWithoutGroupPermission(clusterInstance, GroupProtocol.CONSUMER, true);
}

@ClusterTest
public void testClassicConsumeUnsubscribeWithoutGroupPermission(ClusterInstance clusterInstance) throws ExecutionException, InterruptedException {
testConsumeUnsubscribeWithGroupPermission(clusterInstance, GroupProtocol.CLASSIC);
testConsumeUnsubscribeWithOrWithoutGroupPermission(clusterInstance, GroupProtocol.CLASSIC, false);
}

@ClusterTest
public void testAsyncConsumeUnsubscribeWithoutGroupPermission(ClusterInstance clusterInstance) throws ExecutionException, InterruptedException {
testConsumeUnsubscribeWithGroupPermission(clusterInstance, GroupProtocol.CONSUMER);
testConsumeUnsubscribeWithOrWithoutGroupPermission(clusterInstance, GroupProtocol.CONSUMER, false);
}

private void testConsumeUnsubscribeWithGroupPermission(ClusterInstance clusterInstance, GroupProtocol groupProtocol) throws InterruptedException, ExecutionException {
private void testConsumeUnsubscribeWithOrWithoutGroupPermission(ClusterInstance clusterInstance, GroupProtocol groupProtocol, boolean withGroupPermission) throws InterruptedException, ExecutionException {
setup(clusterInstance);
String topic = "topic";
String group = "group";
Expand Down Expand Up @@ -297,6 +332,13 @@ private void testConsumeUnsubscribeWithGroupPermission(ClusterInstance clusterIn
ConsumerRecords<byte[], byte[]> records = consumer.poll(Duration.ofSeconds(15));
return records.count() == 1;
}, "consumer failed to receive message");
if (!withGroupPermission) {
removeAndVerifyAcls(
Set.of(createAcl(AclOperation.READ, AclPermissionType.ALLOW, CLIENT_PRINCIPAL)),
new ResourcePattern(ResourceType.GROUP, group, PatternType.LITERAL),
clusterInstance
);
}
assertDoesNotThrow(consumer::unsubscribe);
}
}
Expand Down