KAFKA-19406: Remove BrokerTopicStats#removeOldFollowerMetrics #19962
+1
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
gongxuanzhang
added
ci-approved
and removed
core
chia7712
reviewed
Jun 13, 2025
| @@ -2201,9 +2201,7 @@ class ReplicaManager(val config: KafkaConfig, | |||
| private def updateLeaderAndFollowerMetrics(newFollowerTopics: Set[String]): Unit = { | |||
| val leaderTopicSet = leaderPartitionsIterator.map(_.topic).toSet | |||
| newFollowerTopics.diff(leaderTopicSet).foreach(brokerTopicStats.removeOldLeaderMetrics) | |||
There was a problem hiding this comment.
removeOldLeaderMetrics tries to remove REPLICATION_BYTES_OUT_PER_SEC and REASSIGNMENT_BYTES_OUT_PER_SEC which apply across all topics too. Could you please remove them?
m1a2st
approved these changes
Jun 13, 2025
github-actions
bot
added
core
|
LGTM, please correct the Jira number in PR title. |
FrankYang0529
approved these changes
Jun 17, 2025
gongxuanzhang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
about https://issues.apache.org/jira/browse/KAFKA-19406
BTW: whether we should rename
ReplicaManager#updateLeaderAndFollowerMetrics