Skip to content

Conversation

@dejan2609
Copy link
Contributor

Note: this is a #18018 offshoot.

See this comment made by @Goooler: #18018 (comment)

image

FYI @mumrah, @apoorvmittal10

@github-actions github-actions bot added triage PRs from the community build Gradle build or GitHub Actions small Small PRs labels Mar 13, 2025
@apoorvmittal10
Copy link
Contributor

Thanks @dejan2609, can you please confirm the pom and other outputs. If they are same, I ll check them myself too.

@github-actions github-actions bot removed the triage PRs from the community label Mar 14, 2025
@dejan2609
Copy link
Contributor Author

Testing scenario:

  1. create two kafka-clients versions via ./gradlew :clients:publishToMavenLocal -PskipSigning=true
  • use kafka trunk and create kafka-clients version 4.1.0-SNAPSHOT
  • use this PR (and change version in gradle.properties) in order to create 4.2.0-SNAPSHOT version
  1. compare these two versions:
dejan@dejan-HP-ProBook-450-G7:~/kafka$ diff ~/.m2/repository/org/apache/kafka/kafka-clients/4.1.0-SNAPSHOT/kafka-clients-4.1.0-SNAPSHOT.pom ~/.m2/repository/org/apache/kafka/kafka-clients/4.2.0-SNAPSHOT/kafka-clients-4.2.0-SNAPSHOT.pom 
6c6
<   <version>4.1.0-SNAPSHOT</version>
---
>   <version>4.2.0-SNAPSHOT</version>

image

  1. test these two versions created above using this helper project: https://github.com/dejan2609/poc-kafka-18142
  • change kafka-clients version in build.gradle to 4.1.0-SNAPSHOT and create dependency tree:
dejan@dejan-HP-ProBook-450-G7:~/IdeaProjects/terraform/poc-kafka-18142$ ./gradlew dependencies > 4.1.0.txt 
change `kafka-clients` version to 4.2.0-SNAPSHOT
  • change kafka-clients version in build.gradle to 4.2.0-SNAPSHOT and create another dependency tree:
dejan@dejan-HP-ProBook-450-G7:~/IdeaProjects/terraform/poc-kafka-18142$ ./gradlew dependencies > 4.2.0.txt 
  • compare two dependency trees:
dejan@dejan-HP-ProBook-450-G7:~/IdeaProjects/poc-kafka-18142$ diff 4.1.0.txt 4.2.0.txt 
12c12
< \--- org.apache.kafka:kafka-clients:4.1.0-SNAPSHOT
---
> \--- org.apache.kafka:kafka-clients:4.2.0-SNAPSHOT
21c21
< \--- org.apache.kafka:kafka-clients:4.1.0-SNAPSHOT (n)
---
> \--- org.apache.kafka:kafka-clients:4.2.0-SNAPSHOT (n)
27c27
< \--- org.apache.kafka:kafka-clients:4.1.0-SNAPSHOT
---
> \--- org.apache.kafka:kafka-clients:4.2.0-SNAPSHOT
43c43
< +--- org.apache.kafka:kafka-clients:4.1.0-SNAPSHOT
---
> +--- org.apache.kafka:kafka-clients:4.2.0-SNAPSHOT
71c71
< +--- org.apache.kafka:kafka-clients:4.1.0-SNAPSHOT
---
> +--- org.apache.kafka:kafka-clients:4.2.0-SNAPSHOT
dejan@dejan-HP-ProBook-450-G7:~/IdeaProjects/poc-kafka-18142$

@dejan2609
Copy link
Contributor Author

I did some testing and it seems that we are good to go.

@apoorvmittal10 and @mumrah: feel free to review (test on your side).

@dejan2609
Copy link
Contributor Author

Just a reminder for @apoorvmittal10 and @mumrah

@apoorvmittal10
Copy link
Contributor

@dejan2609 Sorry for the delay, I was away for sometime. The PR is on my pending list for review now.

Copy link
Contributor

@apoorvmittal10 apoorvmittal10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @dejan2609 Can you please update the branch to latest please.

@dejan2609 dejan2609 force-pushed the KAFKA-18142-offshoot branch from 8f17d59 to 64eea6e Compare April 22, 2025 07:04
@dejan2609
Copy link
Contributor Author

@apoorvmittal10 Changes are rebased onto trunk.

@apoorvmittal10 apoorvmittal10 merged commit 070892d into apache:trunk Apr 22, 2025
20 checks passed
@dejan2609 dejan2609 deleted the KAFKA-18142-offshoot branch April 22, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Gradle build or GitHub Actions ci-approved small Small PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants