Cherry-pick KAFKA-18583 fix (#18635) to 3.9 #18657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cherry-pick required reimplementing the accompanying test to work with UpdateMetadataRequest (removed in 4.0 and trunk) in order to also apply to `ZkMetadataCache`. If the removal of UpdateMetadataRequest is backported here as well, the test can be changed to match the trunk version. Conflicts: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala
3 tasks
That is 4.0+ only, so we don't have to worry about that. |
dajac
pushed a commit
that referenced
this pull request
Jan 22, 2025
The cherry-pick required reimplementing the accompanying test to work with UpdateMetadataRequest (removed in 4.0 and trunk) in order to also apply to `ZkMetadataCache`. If the removal of UpdateMetadataRequest is backported here as well, the test can be changed to match the trunk version. Reviewers: David Jacot <[email protected]>
|
Merged to 3.9 and 3.8. |
Comment on lines
+714
to
+717
| if (expectedReplicaSet.contains(offlineBrokerId)) { | ||
| assertEquals(expectedReplicaSet, | ||
| replicaSet + offlineBrokerId, | ||
| s"Unexpected partial replica set for partition $partitionId") |
There was a problem hiding this comment.
nit: This condition should also have asserted that replicaSet doesn't contain offlineBrokerId - right now the existing assertEquals will pass even if that's not the case. Also applies to the original trunk change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cherry-pick required reimplementing the accompanying test to work with
UpdateMetadataRequest(removed in 4.0 and trunk) in order to also apply toZkMetadataCache. If the removal ofUpdateMetadataRequestis backported here as well, the test can be changed to match the trunk version.Conflicts: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala
Committer Checklist (excluded from commit message)