Version downgrade for shadow jar plugin #15308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Member
|
@stanislavkozlovski I let you backport to 3.7 |
Member
|
@apoorvmittal10 Thanks for getting to the bottom of this! |
stanislavkozlovski
pushed a commit
that referenced
this pull request
Feb 5, 2024
Reviewers: Mickael Maison <[email protected]>, Andrew Schofield <[email protected]>
Contributor
|
cherry-picked to 3.7 |
yyu1993
pushed a commit
to yyu1993/kafka
that referenced
this pull request
Feb 15, 2024
Reviewers: Mickael Maison <[email protected]>, Andrew Schofield <[email protected]>
Contributor
|
@apoorvmittal10 I am facing an error after this changes I pulled into local Can you help ? |
Contributor
Author
Hi Arpit, the plugin is configured correctly and the version is available. I would advise to check if there is anything custom configured in you setup which point to different repository. |
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
Reviewers: Mickael Maison <[email protected]>, Andrew Schofield <[email protected]>
Phuc-Hong-Tran
pushed a commit
to Phuc-Hong-Tran/kafka
that referenced
this pull request
Jun 6, 2024
Reviewers: Mickael Maison <[email protected]>, Andrew Schofield <[email protected]>
dajac
pushed a commit
that referenced
this pull request
Feb 22, 2025
…16295)" (#19000) The PR: #16295 which changed the shadow plugin version has re-introduced the issue with publication of signed jars, fixed in: #15308. This PR reverts #16295 to unblock Kafka 4.0 release. And we should aim for fixing the issue permanently as being discussed here: #18018. Seems same issue was encountered during `Kafka-3.9` release and same commit was reverted in 3.9 as well: #17218. Reviewers: David Jacot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shadow jar plugin version
8.1.1causes issue when shadowed artifacts aresignedandpublished. The issue occurs becausearchiveBaseNameandarchiveClassifierare not honoured correctly by publication and tries to find the shadow jar which doesn't exist - see GradleUp/shadow#901This PR reverts the shadow plugin version upgrade added in the PR: #13625 and also reverts the workaround to publish signed shadowed jar in the PR: #15127
pomforkafka-clientswhich does include the runtime dependencies.kafka-clients.jarhas correct shaded classes@ijuma The query asked in the PR: #15127 still stands as Gradle Module Metadata is never generated with
shadow jar plugin.cc: @stanislavkozlovski @AndrewJSchofield @xvrl
Committer Checklist (excluded from commit message)