Skip to content

Add more checkpoints in series scan #15856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 11, 2025
Merged

Conversation

shuwenwei
Copy link
Member

Description

Add more checkpoints in series scan

Copy link

codecov bot commented Jul 2, 2025

Codecov Report

Attention: Patch coverage is 56.05096% with 69 lines in your changes missing coverage. Please review.

Project coverage is 39.08%. Comparing base (966cfc7) to head (cfeffe3).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...ource/relational/AbstractAggTableScanOperator.java 0.00% 40 Missing ⚠️
.../source/AbstractSeriesAggregationScanOperator.java 74.35% 10 Missing ⚠️
...r/source/relational/AbstractTableScanOperator.java 0.00% 10 Missing ⚠️
...on/operator/source/AbstractSeriesScanOperator.java 86.95% 3 Missing ⚠️
...gine/execution/operator/source/SeriesScanUtil.java 93.54% 2 Missing ⚠️
...elational/AbstractDefaultAggTableScanOperator.java 0.00% 2 Missing ⚠️
...urce/relational/LastQueryAggTableScanOperator.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #15856      +/-   ##
============================================
- Coverage     39.09%   39.08%   -0.01%     
  Complexity      198      198              
============================================
  Files          4847     4847              
  Lines        315799   315980     +181     
  Branches      39658    39696      +38     
============================================
+ Hits         123448   123491      +43     
- Misses       192351   192489     +138     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

initFirstChunkMetadata();
// filter chunk based on push-down conditions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add back

@@ -434,4 +434,6 @@ public static void tearDown() throws IOException {
BloomFilterCache.getInstance().clear();
EnvironmentUtils.cleanAllDir();
}

protected void assertWithOptionalReturnValue() {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if ununsed, delete it

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
11.1% Duplication on New Code (required ≤ 5%)
B Maintainability Rating on New Code (required ≥ A)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@JackieTien97 JackieTien97 merged commit e6bc39f into master Jul 11, 2025
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants