bugfix: error image when use null value as image query condition in insert on duplicate #704 (#725) #884
+349
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsert on duplicate apache#704 (apache#725) * bugfix apache#704 * bugfix apache#704 * bugfix704-2 * bugfix-test-2 * bugfix-test-2 * pr725 bugfix --------- Co-authored-by: JayLiu <[email protected]> Co-authored-by: FengZhang <[email protected]>
…nadh (apache#772) * fix: Solve the conflict problem of introducing multiple versions of knadh * fix: fix ci fail --------- Co-authored-by: JayLiu <[email protected]> Co-authored-by: FengZhang <[email protected]>
…uest. (apache#764) * feat: add unit test workflow * feat:the ability to automatically run unit tests after creating a pull request. * feat:the ability to automatically run unit tests after creating a pull request. * feat:the ability to automatically run unit tests after creating a pull request. * feat:the ability to automatically run unit tests after creating a pull request. * feat:the ability to automatically run unit tests after creating a pull request. * feat:the ability to automatically run unit tests after creating a pull request. * Optimize/at build lock key performance (apache#837) * Refer to buildlockkey2 optimization apache#829 * Time complexity O(NM)-> O(NK) about buildlockkey and buildlockkey2 Increased readability apache#829 * update import sort apache#829 * update Encapsulation into util packages apache#829 * Support Update join (apache#761) * duplicate image row for update join * update join condition placeholder param error * update join bugfix * Open test annotations * recover update executor * recover update test * recover update test * modified version param --------- Co-authored-by: JayLiu <[email protected]> Co-authored-by: FengZhang <[email protected]> --------- Co-authored-by: jimin <[email protected]> Co-authored-by: JayLiu <[email protected]> Co-authored-by: FengZhang <[email protected]> Co-authored-by: Wiggins <[email protected]> Co-authored-by: lxfeng1997 <[email protected]>
# Conflicts: # .github/workflows/build.yml # go.mod # pkg/datasource/sql/exec/at/base_executor_test.go # pkg/datasource/sql/util/lockkey.go
github-actions
bot
added
bug
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #884 +/- ##
==========================================
+ Coverage 38.17% 38.32% +0.14%
==========================================
Files 188 188
Lines 11417 11476 +59
==========================================
+ Hits 4359 4398 +39
- Misses 6628 6647 +19
- Partials 430 431 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FinnTew
reviewed
Sep 17, 2025
.github/workflows/unit-test.yml
Outdated
| echo "✅ Unit tests completed successfully" | ||
|
|
||
| - name: "Archive test results" | ||
| uses: actions/upload-artifact@v3 |
There was a problem hiding this comment.
In v4, Artifacts are immutable (unless deleted). So you must change each of the uploaded Artifacts to have a different name and filter the downloads by name to achieve the same effect:
jobs:
upload:
strategy:
matrix:
runs-on: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{ matrix.runs-on }}
steps:
- name: Create a File
run: echo "hello from ${{ matrix.runs-on }}" > file-${{ matrix.runs-on }}.txt
- name: Upload Artifact
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
with:
- name: my-artifact
+ name: my-artifact-${{ matrix.runs-on }}
path: file-${{ matrix.runs-on }}.txtRefer to the corresponding GitHub actions document (as above), the CI step related to upload-artifact needs to be modified, including version upgrades and some parameter changes.
Reference document: https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md
There was a problem hiding this comment.
like this ?
`
- name: "Archive test results"
uses: actions/upload-artifact@v4
with:
name: test-results
path: coverage.txt
retention-days: 7
overwrite: true
`
FinnTew
reviewed
Sep 19, 2025
| strategy: | ||
| matrix: | ||
| golang: | ||
| - 1.18 |
There was a problem hiding this comment.
The issue encountered in unit test CI:
../../../go/pkg/mod/go.uber.org/[email protected]/error.go:224:20: undefined: atomic.Bool
This problem may be resolved by upgrading the Go version to 1.20.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: