-
Notifications
You must be signed in to change notification settings - Fork 9
feat(core): transport scheduler integration #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…uling of cyclic tasks 2. Supports JavA-compatible AES encryption and dynamic key management 3. Solve the problem of concurrent map access through one-time password preprocessing 4. Add comprehensive operation statistics and monitoring functions 5. manager message reception
| @@ -1,58 +0,0 @@ | |||
| # | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不需要 image makefile 了吗?
|
|
||
| .PHONY: go-lint | ||
| go-lint: ## run golang lint | ||
| @$(LOG_TARGET) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么删除日志输出?
| @$(LOG_TARGET) | ||
| @version=$$(cat VERSION); \ | ||
| # todo; 添加交叉编译支持 | ||
| CGO_ENABLED=0 GOOS=$(GOOS) GOARCH=$(GOARCH) go build -o bin/collector -ldflags "$(GO_LDFLAGS)" cmd/main.go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这只能在当前系统下编译?似乎对交叉编译不友好?
| @@ -1,35 +0,0 @@ | |||
| # Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
将此重构并移动到根目录?
我目前的想法是镜像的编译和打包在 GHA 中进行,脱离本地,并且同时支持多架构编译。并且这样的镜像体积比上面的小
| strValue = "" // null values become empty strings | ||
| } else { | ||
| switch config.Type { | ||
| case 0: // number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以抽成常亮放在 types 里面,0 1 2 不具有语义和可读性
| } else { | ||
| strValue = fmt.Sprintf("%v", config.Value) | ||
| } | ||
| case 1, 2: // string or password (both are now plain strings after preprocessing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同下
| Calculates []Calculate `json:"calculates"` | ||
| Units []Unit `json:"units"` | ||
| AliasFields []string `json:"aliasFields"` // Alternative field name | ||
| Calculates interface{} `json:"calculates"` // Can be []Calculate or []string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
用 any 而不是 interface
| driverName = "sqlserver" | ||
| } else if strings.Contains(databaseURL, "@tcp(") { | ||
| // MySQL DSN format (no protocol prefix) | ||
| driverName = "mysql" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
抽成 常量定义
1、fix the scheduling accuracy of critical time wheels and the rescheduling of cyclic tasks
2. Supports JavA-compatible AES encryption and dynamic key management
3. Solve the problem of concurrent map access through one-time password preprocessing
4. Add comprehensive operation statistics and monitoring functions
5. manager message reception
todo
1、Send the result to the manager after the task is completed.
...