Skip to content

Conversation

@TJxiaobao
Copy link
Contributor

@TJxiaobao TJxiaobao commented Sep 9, 2025

refactor : Improve the go code specification based on yesterday's opinions.

@TJxiaobao TJxiaobao requested a review from yuluo-yx September 9, 2025 15:00
@TJxiaobao TJxiaobao changed the title Improve dispatching refactor:Improve dispatching Sep 9, 2025
@TJxiaobao TJxiaobao changed the title refactor:Improve dispatching refactor: Improve dispatching Sep 9, 2025
@TJxiaobao TJxiaobao changed the title refactor: Improve dispatching refactor(core): Improve dispatching Sep 9, 2025
cancel context.CancelFunc
mu sync.RWMutex
runningJobs map[int64]*jobtypes.Job
ctx context.Context
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里 context 没有去掉

这些配置应该都在 config 中

Copy link
Member

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 后面的新提 pr 改吧

@yuluo-yx yuluo-yx merged commit db2aa0a into main Sep 9, 2025
6 of 11 checks passed
@TJxiaobao TJxiaobao deleted the reconfiguration_scheduling_resolve_conflicts branch September 13, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants