You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementing ReadBufferManagerV2 as per the new design document.
Following capabilities are added to ReadBufferManager:
Configurable minimum and maximum number of prefetch threads.
Configurable minimum and maximum size of cached buffer pool
Dynamically adjusting thread pool size and buffer pool size based on workload requirement and resource utilization but within the limits defined by user.
Mapping prefetched data to file ETag so that multiple streams reading same file can share the cache and save TPS.
org.apache.hadoop.fs.azurebfs.services.ReadBuffer.getBuffer() may expose internal representation by returning ReadBuffer.buffer At ReadBuffer.java:by returning ReadBuffer.buffer At ReadBuffer.java:[line 111]
org.apache.hadoop.fs.azurebfs.services.ReadBuffer.setBuffer(byte[]) may expose internal representation by storing an externally mutable object into ReadBuffer.buffer At ReadBuffer.java:by storing an externally mutable object into ReadBuffer.buffer At ReadBuffer.java:[line 115]
org.apache.hadoop.fs.azurebfs.services.ReadBuffer.getBuffer() may expose internal representation by returning ReadBuffer.buffer At ReadBuffer.java:by returning ReadBuffer.buffer At ReadBuffer.java:[line 111]
org.apache.hadoop.fs.azurebfs.services.ReadBuffer.setBuffer(byte[]) may expose internal representation by storing an externally mutable object into ReadBuffer.buffer At ReadBuffer.java:by storing an externally mutable object into ReadBuffer.buffer At ReadBuffer.java:[line 115]
Inconsistent synchronization of org.apache.hadoop.fs.azurebfs.services.ReadBufferManagerV2.numberOfActiveBuffers; locked 81% of time Unsynchronized access at ReadBufferManagerV2.java:81% of time Unsynchronized access at ReadBufferManagerV2.java:[line 617]
org.apache.hadoop.fs.azurebfs.services.ReadBuffer.getBuffer() may expose internal representation by returning ReadBuffer.buffer At ReadBuffer.java:by returning ReadBuffer.buffer At ReadBuffer.java:[line 111]
org.apache.hadoop.fs.azurebfs.services.ReadBuffer.setBuffer(byte[]) may expose internal representation by storing an externally mutable object into ReadBuffer.buffer At ReadBuffer.java:by storing an externally mutable object into ReadBuffer.buffer At ReadBuffer.java:[line 115]
Inconsistent synchronization of org.apache.hadoop.fs.azurebfs.services.ReadBufferManagerV2.bufferPool; locked 66% of time Unsynchronized access at ReadBufferManagerV2.java:66% of time Unsynchronized access at ReadBufferManagerV2.java:[line 361]
Inconsistent synchronization of org.apache.hadoop.fs.azurebfs.services.ReadBufferManagerV2.numberOfActiveBuffers; locked 81% of time Unsynchronized access at ReadBufferManagerV2.java:81% of time Unsynchronized access at ReadBufferManagerV2.java:[line 634]
org.apache.hadoop.fs.azurebfs.services.ReadBuffer.getBuffer() may expose internal representation by returning ReadBuffer.buffer At ReadBuffer.java:by returning ReadBuffer.buffer At ReadBuffer.java:[line 111]
org.apache.hadoop.fs.azurebfs.services.ReadBuffer.setBuffer(byte[]) may expose internal representation by storing an externally mutable object into ReadBuffer.buffer At ReadBuffer.java:by storing an externally mutable object into ReadBuffer.buffer At ReadBuffer.java:[line 115]
Inconsistent synchronization of org.apache.hadoop.fs.azurebfs.services.ReadBufferManagerV2.bufferPool; locked 66% of time Unsynchronized access at ReadBufferManagerV2.java:66% of time Unsynchronized access at ReadBufferManagerV2.java:[line 359]
Inconsistent synchronization of org.apache.hadoop.fs.azurebfs.services.ReadBufferManagerV2.numberOfActiveBuffers; locked 81% of time Unsynchronized access at ReadBufferManagerV2.java:81% of time Unsynchronized access at ReadBufferManagerV2.java:[line 632]
org.apache.hadoop.fs.azurebfs.services.ReadBuffer.getBuffer() may expose internal representation by returning ReadBuffer.buffer At ReadBuffer.java:by returning ReadBuffer.buffer At ReadBuffer.java:[line 111]
org.apache.hadoop.fs.azurebfs.services.ReadBuffer.setBuffer(byte[]) may expose internal representation by storing an externally mutable object into ReadBuffer.buffer At ReadBuffer.java:by storing an externally mutable object into ReadBuffer.buffer At ReadBuffer.java:[line 115]
Inconsistent synchronization of org.apache.hadoop.fs.azurebfs.services.ReadBufferManagerV2.numberOfActiveBuffers; locked 81% of time Unsynchronized access at ReadBufferManagerV2.java:81% of time Unsynchronized access at ReadBufferManagerV2.java:[line 635]
org.apache.hadoop.fs.azurebfs.services.ReadBuffer.getBuffer() may expose internal representation by returning ReadBuffer.buffer At ReadBuffer.java:by returning ReadBuffer.buffer At ReadBuffer.java:[line 111]
org.apache.hadoop.fs.azurebfs.services.ReadBuffer.setBuffer(byte[]) may expose internal representation by storing an externally mutable object into ReadBuffer.buffer At ReadBuffer.java:by storing an externally mutable object into ReadBuffer.buffer At ReadBuffer.java:[line 115]
Inconsistent synchronization of org.apache.hadoop.fs.azurebfs.services.ReadBufferManagerV2.numberOfActiveBuffers; locked 81% of time Unsynchronized access at ReadBufferManagerV2.java:81% of time Unsynchronized access at ReadBufferManagerV2.java:[line 640]
Write to static field org.apache.hadoop.fs.azurebfs.services.ReadBufferManagerV2.cpuMonitorThread from instance method org.apache.hadoop.fs.azurebfs.services.ReadBufferManagerV2.init() At ReadBufferManagerV2.java:from instance method org.apache.hadoop.fs.azurebfs.services.ReadBufferManagerV2.init() At ReadBufferManagerV2.java:[line 179]
Write to static field org.apache.hadoop.fs.azurebfs.services.ReadBufferManagerV2.memoryMonitorThread from instance method org.apache.hadoop.fs.azurebfs.services.ReadBufferManagerV2.init() At ReadBufferManagerV2.java:from instance method org.apache.hadoop.fs.azurebfs.services.ReadBufferManagerV2.init() At ReadBufferManagerV2.java:[line 157]
org.apache.hadoop.fs.azurebfs.services.ReadBuffer.getBuffer() may expose internal representation by returning ReadBuffer.buffer At ReadBuffer.java:by returning ReadBuffer.buffer At ReadBuffer.java:[line 111]
org.apache.hadoop.fs.azurebfs.services.ReadBuffer.setBuffer(byte[]) may expose internal representation by storing an externally mutable object into ReadBuffer.buffer At ReadBuffer.java:by storing an externally mutable object into ReadBuffer.buffer At ReadBuffer.java:[line 115]
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: https://issues.apache.org/jira/browse/HADOOP-19622
Implementing ReadBufferManagerV2 as per the new design document.
Following capabilities are added to ReadBufferManager:
For more details on design doc please refer to the design doc attached to parent JIRA: https://issues.apache.org/jira/browse/HADOOP-19596
How was this patch tested?
TBA