-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19588. S3A support for S3 express access points #7746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
revathivijay
wants to merge
4
commits into
apache:trunk
Choose a base branch
from
revathivijay:trunk
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+84
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 -1 overall
This message was automatically generated. |
@revathivijay can you update your PR title to |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Currently, the endpoint for using S3 accesspoint is resolved for S3 and S3 on outposts: https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/ArnResource.java#L29-L30. However, for s3express, the endpoint is
s3express-<zoneId>.<region>.amazonaws.com
. (https://docs.aws.amazon.com/AmazonS3/latest/userguide/directory-bucket-az-networking.html). PR adds support for this.Additionally, for accessing objects using s3express in the
S3AFileSystem
, we need to parse the access point ARN for an S3express access point into the access point name, since ARNs aren't supported on S3express other than in IAM policies. (https://docs.aws.amazon.com/AmazonS3/latest/userguide/access-points-directory-buckets-restrictions-limitations-naming-rules.html). This PR also addresses this change.Update the SDK version used by the changes to
2.31.12
, which is the version (at minimum) needed to use s3express access points. It does not do the SDK upgrade, but only the version of the dependency.How was this patch tested?
mvn clean install -DskipTests
TestArnResource
:hadoop-aws
folder since I didn't see it run in the above:Additional info:
I set up
auth-keys.xml
as explained in https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/filesystem/testing.html#Running_the_tests, and used bucket name as an S3express access point to test against it. But running into some JUnit version errors (pasted some sample errors below), which I believe is related to JUnit upgrade.For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?