-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19343. Add support for open() and rename() #7742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: HADOOP-19343
Are you sure you want to change the base?
HADOOP-19343. Add support for open() and rename() #7742
Conversation
Closes apache#7656 Signed-off-by: Chris Nauroth <[email protected]>
Closes apache#7721 Signed-off-by: Chris Nauroth <[email protected]>
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arunkumarchacko , thank you for this patch. It mostly looks good. I entered a few minor nitpicks.
...ls/hadoop-gcp/src/main/java/org/apache/hadoop/fs/gs/GoogleCloudStorageClientReadChannel.java
Outdated
Show resolved
Hide resolved
hadoop-tools/hadoop-gcp/src/main/java/org/apache/hadoop/fs/gs/Gs.java
Outdated
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, will commit to the feature branch shortly.
Closes #7742 Signed-off-by: Chris Nauroth <[email protected]>
Closes #7742 Signed-off-by: Chris Nauroth <[email protected]>
Description of PR
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?