-
Notifications
You must be signed in to change notification settings - Fork 13.7k
[FLINK-37797] Model documentation #26694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. I left some comments.
TABLE input_table, | ||
MODEL model_name, | ||
DESCRIPTOR(feature_columns), | ||
[CONFIG => MAP['key', 'value']] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better use
SELECT * FROM
ML_PREDICT(
TABLE input_table,
MODEL model_name,
DESCRIPTOR(feature_columns),
[MAP['key', 'value']]
Because flink only supports:
- all arguments use named argument
- all arguments don't use named argument
We get an error for the following statement:
SELECT id, len, z
FROM ML_PREDICT(TABLE nullable_src, MODEL m2, DESCRIPTOR(`id`, `len`), CONFIG => MAP['async','false'])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of the change
Documentation for model DDL
Verifying this change
Built doc locally
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation