-
Notifications
You must be signed in to change notification settings - Fork 184
[hotfix] [docs] Fix typos #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix typos * Make snippets consistent * Add link to Python SDK in further work section
As far as I can tell, flink-statefun is only available under ververica in DockerHub.
…-blocks.md These sections are treated as bullet points about stateful functions. Thus, it feels more natural to have them as subsections.
* Plural of egress seems to be egresses (https://en.wiktionary.org/wiki/egress)
* Fix typos * Add link to Java SDK in further work section
tzulitai
reviewed
Jul 1, 2020
igalshilman
reviewed
Jul 6, 2020
igalshilman
reviewed
Jul 6, 2020
This reverts commit 72720c5.
Applies Seth's suggestion from the review.
Author
|
@sjwiesman @igalshilman @tzulitai I reverted the Docker image repository change and applied Seth's suggestion for the function types. Can you take another look and merge or close this PR? |
Contributor
|
Thanks @uce, will merge this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really helpful documentation! Yesterday, I read over most of the docs and found a few typos, including some typos in code. Feel free to push back on any of the changes that seem unnecessary to you.
A few nit comments:
mvn clean packageproduces an uber JAR which is not true. Is the intention to provide a Maven configuration that does create an uber JAR or are the docs mistaken?Anytype.