docs(apisix): 从快速开始里去掉 MySQL,说明 Derby 默认配置 (#1087)#1101
Merged
Conversation
Member
|
merge to main to fix ci fail |
The Nacos compose file (`nacos2.0.3-compose/docker-compose.yml`) sets `SPRING_DATASOURCE_PLATFORM=derby`, with the MYSQL_SERVICE_* vars commented out. So in the demo path, Nacos uses its embedded Derby store and does not connect to MySQL at all — yet the README still asked users to start a MySQL container and `sleep 10`. Two consequences: - New users spend extra time pulling/booting MySQL for nothing, blocking the rest of the quick-start. - It's confusing why both compose files coexist: the docs imply MySQL is required, the actual config says it isn't. Update both English and Chinese READMEs: - Remove the MySQL start step (and its `sleep 10`) from the quick-start sequence so the demo uses what the config actually expects (etcd + Nacos + APISIX). - Add a short note explaining that Nacos uses embedded Derby, that the `mysql5.7-compose` directory is kept as a reference for production-like setups, and how to opt in (start MySQL + uncomment the env vars in the Nacos compose). No code or compose-file changes; the MySQL compose is preserved so users who want persistence can still use it. Closes apache#1087
6dee851 to
1ef87b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
nacos2.0.3-compose/docker-compose.yml里设置的是SPRING_DATASOURCE_PLATFORM=derby,MySQL相关环境变量都是注释状态。所以在示例的运行路径下,Nacos 用的是内嵌 Derby,完全不连 MySQL。
但 README 仍然让用户:
带来两个问题:
修复
中英文 README 同步更新(不动代码、不动 compose 文件):
sleep 10移除,让步骤跟配置实际所需的服务一致(etcd + Nacos + APISIX)mysql5.7-compose目录保留作为生产级配置的参考,以及如何按需启用(启 MySQL + 取消 Nacos compose 里 MySQL环境变量的注释)
mysql5.7-compose目录保留,希望用持久化存储的用户仍可使用。Closes #1087