refactor: enforce 1 tierAlias mapping per distinct tier. add tierAlias dim to some metrics#19595
Open
capistrant wants to merge 2 commits into
Open
refactor: enforce 1 tierAlias mapping per distinct tier. add tierAlias dim to some metrics#19595capistrant wants to merge 2 commits into
capistrant wants to merge 2 commits into
Conversation
Contributor
Author
|
@jtuglu1 can you comment on if I am wrong in assuming that tiers should never belong to more than one alias? It is an assumption I made and created enforcement for because it made the metrics story more straight forward. But I don't want to clobber your initial intentions without discussion |
Contributor
|
I think this seems reasonable to me – we currently are only using it in a way where 1 physical tier is aliased to at most 1 other virtual tier. It's worth considering whether we'd want to support multiple aliases (e.g. 1 physical tier being union of 2+ virtual tiers), but I think it's a fine assertion to make for now. |
jtuglu1
approved these changes
Jun 17, 2026
| throw InvalidInput.exception( | ||
| "historicalTierAliases [%s] is invalid. Physical tier%s %s cannot belong to more than one alias.", | ||
| this.historicalTierAliases, | ||
| duplicateTiers.size() > 1 ? "s" : "", |
Contributor
There was a problem hiding this comment.
nit: can we just do something like:
Physical tier(s) [%s] cannot...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1 associated alias enforcement
Explicitly enforce historical tiers belonging to a single alias.
Add tierAlias dimension to metrics
When using aliasing, it is helpful to have some associated tier based metrics report the alias the tier belongs to. This can make monitoring/alerting easier in clusters where you care more about the aggregate tier metrics than individual tiers.
Release note
Strictly forbid a historical tier from being associated with more than one tier alias. Add tierAlias dimension to some tiered metrics, allowing aggregation across aliases more easily on the monitoring/alerting side.
Key changed/added classes in this PR
CoordinatorDynamicConfigPrepareBalancerAndLoadQueuesThis PR has: