fix: cost autoscaler flaky test#19594
Open
Shekharrajak wants to merge 2 commits into
Open
Conversation
Shekharrajak
changed the title
Shekharrajak
commented
Jun 17, 2026
|
|
||
| cluster.callApi().postSupervisor(supervisor.createSuspendedSpec()); | ||
| cluster.callApi().waitForAllSegmentsToBeAvailable(dataSource, coordinator, broker); | ||
| Assertions.assertEquals("10000", cluster.runSql("SELECT COUNT(*) FROM %s", dataSource)); |
Contributor
Author
There was a problem hiding this comment.
Assert final row count from the actual number of published records.
Shekharrajak
commented
Jun 17, 2026
| ); | ||
| } | ||
| finally { | ||
| keepPublishing.set(false); |
Contributor
Author
There was a problem hiding this comment.
Clean up publisher and suspend supervisor
Shekharrajak
commented
Jun 17, 2026
| overlord.latchableEmitter().waitForEvent( | ||
| event -> event.hasMetricName(OPTIMAL_TASK_COUNT_METRIC) | ||
| .hasDimension(DruidMetrics.SUPERVISOR_ID, supervisor.getId()) | ||
| .hasValueMatching(Matchers.greaterThan(1L)) |
Contributor
Author
There was a problem hiding this comment.
wait until the cost-based autoscaler computes that the optimal task count is greater than 1. This is only the autoscaler recommendation.
Shekharrajak
commented
Jun 17, 2026
| overlord.latchableEmitter().waitForEvent( | ||
| event -> event.hasMetricName("task/autoScaler/updatedCount") | ||
| .hasDimension(DruidMetrics.SUPERVISOR_ID, supervisor.getId()) | ||
| .hasValueMatching(Matchers.greaterThan(1L)) |
Contributor
Author
There was a problem hiding this comment.
This is the applied scale-up event.
Shekharrajak
commented
Jun 17, 2026
| final AtomicInteger totalRecords = new AtomicInteger(); | ||
| final ExecutorService publisher = Executors.newSingleThreadExecutor(); | ||
| final Future<?> publisherFuture = publisher.submit(() -> { | ||
| for (int i = 0; i < MAX_SCALE_UP_RECORD_BATCHES && keepPublishing.get(); ++i) { |
Contributor
Author
There was a problem hiding this comment.
instead of publishing 10k records upfront and then waiting, the test keeps publishing records in the background while the autoscaler is running. This gives the autoscaler a
stable lag signal to observe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref. #19517
Description
Fixes flaky
CostBasedAutoScalerIntegrationTestscale-up wait.This PR has: