Add string utils repeat chars x times #1401
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n, boolean) TODO - Fix Javadoc plugin issue Signed-off-by: trungpnt-byte <[email protected]>
Signed-off-by: trungpnt-byte <[email protected]>
Signed-off-by: trungpnt-byte <[email protected]>
Signed-off-by: trungpnt-byte <[email protected]>
…sibleLen instead of constantly multiplying existing len by 2 Signed-off-by: trungpnt-byte <[email protected]>
|
Hi @trungpnt-byte, This PR looks like a modified version of your earlier proposal in #1398. Could you take a moment to respond to the questions raised there? Specifically:
Understanding the broader use case will help us assess whether this addition makes sense for the library as a whole. |
|
Hello @trungpnt-byte, I don't think we want to grow the public API in this class with these kinds of hyper-specifc and complex methods beyond what we already have. This looks like a duplicate of #1398, which causes additional churn for maintainers. All the comments from #1398 stand IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.