Skip to content

ui: bump UI dependencies versions #8923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

rohityadavcloud
Copy link
Member

Bumps up versions for ant and other dependencies to latest/stable minors.

This is just regular maintenance work, but not migrating to major versions of dependencies.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Built and ran it locally using npm v16 on Mac osx arm64.

How did you try to break this feature and the system with this change?

Bumps up versions for ant and other dependencies to latest/stable
minors.

Signed-off-by: Rohit Yadav <[email protected]>
@rohityadavcloud
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@rohityadavcloud
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8923 (QA-JID-314)

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, maybe even a higher npm version?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.53%. Comparing base (c7626eb) to head (acf5e61).
Report is 8 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #8923      +/-   ##
============================================
+ Coverage     15.36%   18.53%   +3.17%     
- Complexity    13620    17105    +3485     
============================================
  Files          4862     4863       +1     
  Lines        325934   326041     +107     
  Branches      45814    45840      +26     
============================================
+ Hits          50074    60429   +10355     
+ Misses       268857   256690   -12167     
- Partials       7003     8922    +1919     
Flag Coverage Δ
simulator-marvin-tests 18.53% <ø> (+3.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9276

Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm
Did some monkey testing on the UI build and didn't see any issues.

@DaanHoogland DaanHoogland reopened this Apr 16, 2024
@DaanHoogland DaanHoogland merged commit 44b8d3a into apache:4.19 Apr 17, 2024
@DaanHoogland DaanHoogland deleted the ui-deps-upgrade branch April 17, 2024 07:09
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

6 participants