-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ui: bump UI dependencies versions #8923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps up versions for ant and other dependencies to latest/stable minors. Signed-off-by: Rohit Yadav <[email protected]>
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
@blueorangutan package |
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, maybe even a higher npm version?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #8923 +/- ##
============================================
+ Coverage 15.36% 18.53% +3.17%
- Complexity 13620 17105 +3485
============================================
Files 4862 4863 +1
Lines 325934 326041 +107
Branches 45814 45840 +26
============================================
+ Hits 50074 60429 +10355
+ Misses 268857 256690 -12167
- Partials 7003 8922 +1919
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9276 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Did some monkey testing on the UI build and didn't see any issues.
Signed-off-by: Rohit Yadav <[email protected]>
Bumps up versions for ant and other dependencies to latest/stable minors.
This is just regular maintenance work, but not migrating to major versions of dependencies.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Built and ran it locally using npm v16 on Mac osx arm64.
How did you try to break this feature and the system with this change?