removed code in comments #11145
removed code in comments #11145
Conversation
boring-cyborg
bot
added
component:api
component:console-proxy
component:networking
component:orchestration
component:primary-storage
component:secondary-storage
component:ssvm
component:storage
component:XenServer
Python
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up commented-out code across multiple modules and updates various comment headers and Javadoc links.
- Removed leftover debug and commented code in Java and Python files
- Corrected license header comments in API commands
- Updated Javadoc
@seelink formatting
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| utils/src/main/java/com/cloud/utils/xmlobject/XmlObjectParser.java | Removed commented-out debug System.out.println |
| utils/src/main/java/com/cloud/utils/xmlobject/XmlObject.java | Removed commented-out debug System.out.println |
| services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/template/UploadManagerImpl.java | Removed commented-out method call |
| services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java | Removed commented-out path logic |
| services/console-proxy/rdpconsole/src/main/java/vncclient/vnc/Vnc33Hello.java | Removed commented debug properties |
| services/console-proxy/rdpconsole/src/main/java/rdpclient/rdp/ClientConfirmActivePDU.java | Updated Javadoc @see link formatting |
| services/console-proxy/rdpconsole/src/main/java/rdpclient/clip/ClipboardDataFormat.java | Removed commented-out clipboard formats |
| services/console-proxy/rdpconsole/src/main/java/rdpclient/RdpClient.java | Removed commented-out debug override |
| scripts/vm/hypervisor/xenserver/xenserver56fp1/NFSSR.py | Removed commented-out directory-creation logic |
| scripts/vm/hypervisor/xenserver/xcpserver/NFSSR.py | Removed commented-out directory-creation logic |
| scripts/vm/hypervisor/xenserver/xcposs/NFSSR.py | Removed commented-out directory-creation logic |
| scripts/vm/hypervisor/xenserver/perfmon.py | Removed commented-out XenAPI pool code |
| scripts/vm/hypervisor/ovm3/cloudstack.py | Removed commented-out OVS agent commands |
| plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/util/StorPoolHelper.java | Removed commented-out custom logger setup |
| plugins/storage/volume/nexenta/src/main/java/org/apache/cloudstack/storage/datastore/driver/NexentaPrimaryDataStoreDriver.java | Removed commented-out DAO update call |
| plugins/network-elements/juniper-contrail/src/test/java/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java | Simplified exception handling in test mock |
| plugins/network-elements/cisco-vnmc/src/main/java/com/cloud/network/cisco/CiscoVnmcConnectionImpl.java | Removed commented-out XML concatenation logic |
| engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/VolumeDataStoreVO.java | Removed commented-out constructor calls |
| engine/schema/src/main/java/com/cloud/dc/dao/ClusterVSMMapDaoImpl.java | Removed redundant super() call |
| engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java | Removed commented ISO-handling code |
| api/src/main/java/org/apache/cloudstack/api/command/user/template/ListTemplatePermissionsCmd.java | Corrected license header comment |
| api/src/main/java/org/apache/cloudstack/api/command/user/iso/ListIsoPermissionsCmd.java | Corrected license header comment |
| api/src/main/java/org/apache/cloudstack/api/command/admin/template/ListTemplatePermissionsCmdByAdmin.java | Corrected license header comment |
| api/src/main/java/org/apache/cloudstack/api/command/admin/iso/ListIsoPermissionsCmdByAdmin.java | Corrected license header comment |
Comments suppressed due to low confidence (2)
services/console-proxy/rdpconsole/src/main/java/rdpclient/rdp/ClientConfirmActivePDU.java:30
- [nitpick] The Javadoc link text is not descriptive; consider updating the anchor text to something like 'MSDN documentation for Client Confirm Active PDU' to improve clarity.
* @see <a href="http://msdn.microsoft.com/en-us/library/cc240488.aspx">microsoft msdn explanation</a>
api/src/main/java/org/apache/cloudstack/api/command/user/template/ListTemplatePermissionsCmd.java:1
- The license header seems incomplete and ends abruptly; please restore the full standard ASF header (e.g., 'under one or more contributor license agreements').
// Licensed to the Apache Software Foundation (ASF) under one
...il/src/test/java/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11145 +/- ##
============================================
- Coverage 16.76% 16.65% -0.11%
+ Complexity 14285 14249 -36
============================================
Files 5767 5767
Lines 512657 512600 -57
Branches 62359 62352 -7
============================================
- Hits 85950 85378 -572
- Misses 417108 417668 +560
+ Partials 9599 9554 -45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DaanHoogland
force-pushed
the
ghi3777-codeInComments
branch
from
11067b5 to
51881bc
Compare
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14084 |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14087 |
|
@blueorangutan test matrix |
|
@DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-13715)
|
|
[SF] Trillian test result (tid-13716)
|
|
[SF] Trillian test result (tid-13718)
|
|
[SF] Trillian test result (tid-13717)
|
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14320 |
|
@blueorangutan test matrix |
|
@DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-13866)
|
|
[SF] Trillian test result (tid-13865)
|
|
[SF] Trillian test result (tid-13868)
|
|
[SF] Trillian test result (tid-13867)
|
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14370 |
Description
This PR fixes: #3777 using ai help a lot of code in comments was removed. By far not complete yet as “token expired”. Also I had to revert a lot of the suggestions as they where either completely invalid or not relevant to the premise “not-explanetary code in comment” , like diamond operators 🤯 or log rephrasing 😡 .
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?