Management Server - Prepare for Maintenance and Cancel Maintenance improvements

[sureshanaparti]

Description

This PR has the following improvements for Management Server - Prepare for Maintenance and Cancel Maintenance.

• Added new setting 'management.server.maintenance.ignore.maintenance.hosts' to ignore hosts in maintenance states while preparing management server for maintenance. This skips agent transfer and agents count check for hosts in maintenance, and unblocks Management Server in "preparing for maintenance" state when any Host stuck in "prepare for maintenance" (due to connectivity/race condition issues) or in other maintenance states.
• Rebalance indirect agents after cancel maintenance, using rebalance parameter in cancelMaintenance API, to initiate the rebalancing of the indirect agents immediately instead of waiting for the 'indirect.agent.lb.check.interval' time.
• Force maintenance after maintenance window timeout, using forced parameter in prepareForMaintenance API, in case migrate agents failed & they can re-connect to other available management node.
• Propagate 'indirect.agent.lb.check.interval' setting change to the host agents.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 16.48352% with 152 lines in your changes missing coverage. Please review.

Project coverage is 16.57%. Comparing base (41b4f0a) to head (835a5ab).
Report is 21 commits behind head on main.

Files with missing lines	Patch %	Lines
...loudstack/agent/lb/IndirectAgentLBServiceImpl.java	10.93%	56 Missing and 1 partial ⚠️
.../src/main/java/com/cloud/host/dao/HostDaoImpl.java	0.00%	25 Missing ⚠️
.../cloud/configuration/ConfigurationManagerImpl.java	0.00%	18 Missing ⚠️
...enance/ManagementServerMaintenanceManagerImpl.java	51.61%	13 Missing and 2 partials ⚠️
...cloud/agent/manager/ClusteredAgentManagerImpl.java	0.00%	13 Missing ⚠️
agent/src/main/java/com/cloud/agent/Agent.java	0.00%	9 Missing ⚠️
...apache/cloudstack/agent/lb/SetupMSListCommand.java	0.00%	4 Missing ⚠️
...e/cloudstack/api/command/CancelMaintenanceCmd.java	0.00%	3 Missing ⚠️
...oudstack/api/command/PrepareForMaintenanceCmd.java	0.00%	3 Missing ⚠️
...pareForMaintenanceManagementServerHostCommand.java	25.00%	3 Missing ⚠️
... and 2 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #10995      +/-   ##
============================================
- Coverage     16.57%   16.57%   -0.01%     
+ Complexity    13870    13869       -1     
============================================
  Files          5719     5719              
  Lines        507200   507314     +114     
  Branches      61574    61593      +19     
============================================
+ Hits          84093    84100       +7     
- Misses       413688   413792     +104     
- Partials       9419     9422       +3     

Flag	Coverage Δ
uitests	3.96% <ø> (-0.01%)	⬇️
unittests	17.45% <16.48%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13687

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13488)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 60623 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10995-t13488-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[harikrishna-patnala]

code LGTM

[harikrishna-patnala]

@sureshanaparti I guess this is ready for review ?